> On May 22, 2014, 1:37 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 677 > > <https://reviews.apache.org/r/20955/diff/4/?file=584744#file584744line677> > > > > This is causing problems on Mac OS X/clang: > > ../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:677:10: > > error: conversion from > > 'Unreachable' to 'Result<uid_t>' is ambiguous > > return UNREACHABLE();
fix in https://reviews.apache.org/r/21777 > On May 22, 2014, 1:37 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 721 > > <https://reviews.apache.org/r/20955/diff/4/?file=584744#file584744line721> > > > > And here: > > > > ../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:721:10: > > error: conversion from > > 'Unreachable' to 'Result<gid_t>' is ambiguous fix in https://reviews.apache.org/r/21777 - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review43771 ----------------------------------------------------------- On May 19, 2014, 3:58 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 3:58 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 3e511355e1faf7160442799e1e08d59b6f3b2f37 > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
