----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review45103 -----------------------------------------------------------
src/launcher/fetcher.cpp <https://reviews.apache.org/r/21734/#comment79770> Mind introducing a const string for "file://" and do a .length()/.size() here? Magic numbers are error prone. src/launcher/fetcher.cpp <https://reviews.apache.org/r/21734/#comment79771> Same here. - Niklas Nielsen On June 9, 2014, 11:36 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 11:36 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am 4a3f2e1 > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
