> On June 16, 2014, 10:50 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 158 > > <https://reviews.apache.org/r/21734/diff/10/?file=606960#file606960line158> > > > > Do you need to set up a local cluster to test the fetcher or can you > > test the fetcher in isolation? > > > > E.g., you could run the test in a temporary directory, creating files, > > and then running the fetcher and checking it fetches the files correctly. > > > > I don't see anything in the tests that requires using the full stack so > > these tests could be vastly simplified.
I guess technically if just testing the change alone perhaps not, just thinking to verify the fetcher works within mesos we should have unit tests in place to do so. I can modify it so it simply just launches the fetcher passed in a file uri command if you think we don't need this for now. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review45850 ----------------------------------------------------------- On June 16, 2014, 8:21 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 8:21 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am c91b438 > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
