----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review45850 -----------------------------------------------------------
src/launcher/fetcher.cpp <https://reviews.apache.org/r/21734/#comment80849> Shouldn't FILE_URI_LOCALHOST be just "localhost"? i.e., it's file:///path or file://localhost/path, in both cases it's file:// + host + /path Would it be more explicit to have FILE_URI_LOCALHOST = "file://localhost"? this also avoids the nesting later. src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment80852> can you not use Error("")? src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment80853> I don't think the Option<string> needs to be explicitly constructed. src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment80851> Do you need to set up a local cluster to test the fetcher or can you test the fetcher in isolation? E.g., you could run the test in a temporary directory, creating files, and then running the fetcher and checking it fetches the files correctly. I don't see anything in the tests that requires using the full stack so these tests could be vastly simplified. - Ian Downes On June 16, 2014, 1:21 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 1:21 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am c91b438 > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
