> On June 10, 2014, 11:30 a.m., Dominic Hamon wrote:
> > src/master/master.hpp, line 530
> > <https://reviews.apache.org/r/22316/diff/2/?file=606511#file606511line530>
> >
> > Are we going to add more of these? It might make sense to combine them:
> >
> > struct PerFrameworkPrincipalMetrics
> > {
> > process::metrics::Counter received;
> > process::metrics::Counter processed;
> > };
> >
> > hashmap<std::string, process::Owned<PerFrameworkPrincipalMetrics> >
> > perFrameworkPrincipalMetrics;
> >
> > what do you think?
None that I can think of.
This feels nice but with only two of them it's a little odd for it to look much
different from everything else, especially
std::vector<process::metrics::Gauge> resources_total;
std::vector<process::metrics::Gauge> resources_used;
std::vector<process::metrics::Gauge> resources_percent;
Maybe refactor later when there are more?
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/#review45261
-----------------------------------------------------------
On June 11, 2014, 10:39 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22316/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 10:39 a.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1339
> https://issues.apache.org/jira/browse/MESOS-1339
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Multiple frameworks use the same principal use the same counter.
>
>
> Diffs
> -----
>
> src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd
> src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59
> src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
