> On June 17, 2014, 7:57 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 588 > > <https://reviews.apache.org/r/22579/diff/3/?file=610308#file610308line588> > > > > Just an FYI, the mesos-executor should get installed in the same place > > as mesos-health-checker so you should just be able to use the > > dirname(argv[0]) to find it. Were you adding this so that people could > > override that location?
Ah I didn't know that, I was trying to just get the dirname :) Will do that instead. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review45845 ----------------------------------------------------------- On June 17, 2014, 5:59 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22579/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Added task health check process that is launched with the command executor if > health check is configured. > It runs configured health check command and return the status to the executor > to report the task health. The executor also reports the task health status > back to the scheduler. > > The task health process keeps internal state based on health check > configuration, and determine when the task it is checking for should be > killed. Currently it's based on the number of consecutive failures it > observed. Once the condition meets it sends a task health status update with > a kill task flag turned on, and the executor will kill the task. > > > Diffs > ----- > > include/mesos/mesos.proto 709b8b1 > src/Makefile.am 3e623cc > src/common/type_utils.hpp 784a808 > src/health-check/main.cpp PRE-CREATION > src/launcher/executor.cpp 3d55d93 > src/messages/messages.proto 8aecc8b > src/slave/http.cpp cd7f692 > src/slave/slave.cpp bc976b7 > src/tests/health_check_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22579/diff/ > > > Testing > ------- > > Added unit tests and make check. > > > Thanks, > > Timothy Chen > >
