----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review46301 -----------------------------------------------------------
Ship it! src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81604> Avoid 'using' in header. src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81605> s/" has exited/"exited/ src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81606> s/" has exited/"exited/ src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81607> } // namespace status { } // namespace internal { } // namespace mesos { src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81608> #endif // __STATUS_UTILS_HPP__ src/common/status_utils.hpp <https://reviews.apache.org/r/22579/#comment81609> Kill the newline. src/common/type_utils.hpp <https://reviews.apache.org/r/22579/#comment81610> << " is " << update.status().healthy() ? "healthy" : "unhealthy"; src/health-check/main.cpp <https://reviews.apache.org/r/22579/#comment81611> s/_check/_healthCheck/ src/health-check/main.cpp <https://reviews.apache.org/r/22579/#comment81612> One per line. src/launcher/executor.cpp <https://reviews.apache.org/r/22579/#comment81614> . src/launcher/executor.cpp <https://reviews.apache.org/r/22579/#comment81613> One per line. src/slave/slave.cpp <https://reviews.apache.org/r/22579/#comment81615> Unused code. - Benjamin Hindman On June 20, 2014, 8:35 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22579/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 8:35 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Added task health check process that is launched with the command executor if > health check is configured. > It runs configured health check command and return the status to the executor > to report the task health. The executor also reports the task health status > back to the scheduler. > > The task health process keeps internal state based on health check > configuration, and determine when the task it is checking for should be > killed. Currently it's based on the number of consecutive failures it > observed. Once the condition meets it sends a task health status update with > a kill task flag turned on, and the executor will kill the task. > > > Diffs > ----- > > include/mesos/mesos.proto 2f6be05 > src/Makefile.am b1b7d2d > src/common/status_utils.hpp PRE-CREATION > src/common/type_utils.hpp 27ea4d2 > src/health-check/main.cpp PRE-CREATION > src/launcher/executor.cpp 3d55d93 > src/master/master.cpp dcf28ad > src/messages/messages.proto 8aecc8b > src/slave/containerizer/external_containerizer.cpp 96c434b > src/slave/slave.cpp ed3483f > src/tests/health_check_tests.cpp PRE-CREATION > src/tests/script.cpp d57fc7d > > Diff: https://reviews.apache.org/r/22579/diff/ > > > Testing > ------- > > Added unit tests and make check. > > > Thanks, > > Timothy Chen > >
