-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22579/#review46102
-----------------------------------------------------------
Bad patch!
Reviews applied: [22579]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
zip_safe flag not set; analyzing archive contents...
../../src/health-check/main.cpp: In member function 'void
mesos::internal::HealthCheckerProcess::failure(const string&)':
../../src/health-check/main.cpp:103:71: error: comparison between signed and
unsigned integer expressions [-Werror=sign-compare]
cc1plus: all warnings being treated as errors
make[3]: *** [health-check/mesos_health_check-main.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On June 18, 2014, 7:36 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22579/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 7:36 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added task health check process that is launched with the command executor if
> health check is configured.
> It runs configured health check command and return the status to the executor
> to report the task health. The executor also reports the task health status
> back to the scheduler.
>
> The task health process keeps internal state based on health check
> configuration, and determine when the task it is checking for should be
> killed. Currently it's based on the number of consecutive failures it
> observed. Once the condition meets it sends a task health status update with
> a kill task flag turned on, and the executor will kill the task.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2f6be05
> src/Makefile.am b1b7d2d
> src/common/status_utils.hpp PRE-CREATION
> src/common/status_utils.cpp PRE-CREATION
> src/common/type_utils.hpp 27ea4d2
> src/health-check/main.cpp PRE-CREATION
> src/launcher/executor.cpp 3d55d93
> src/master/master.cpp 888657d
> src/messages/messages.proto 8aecc8b
> src/slave/containerizer/external_containerizer.cpp b5d0c4c
> src/slave/slave.cpp bc976b7
> src/tests/health_check_tests.cpp PRE-CREATION
> src/tests/script.cpp 9f1be63
>
> Diff: https://reviews.apache.org/r/22579/diff/
>
>
> Testing
> -------
>
> Added unit tests and make check.
>
>
> Thanks,
>
> Timothy Chen
>
>
