----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review46168 -----------------------------------------------------------
Patch looks great! Reviews applied: [21799] All tests passed. - Mesos ReviewBot On June 18, 2014, 8:24 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21799/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 8:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Fixes to enable cgroups to function when initialized via systemd defaults: > + Fix for co-mounting cpu,cpuacct > + Fix for nested cgroups_root='system.slice/mesos-slave.service' > + Diagnostics to propagate error details. > > > Diffs > ----- > > src/linux/cgroups.hpp 75c5602 > src/linux/cgroups.cpp a4274a8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 > src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f9 > > Diff: https://reviews.apache.org/r/21799/diff/ > > > Testing > ------- > > make check + > > ran jobs via Marathon and verified isolation. > > > Thanks, > > Timothy St. Clair > >
