----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review45052 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79743> What about writing this so it looks more like a set equality test, i.e., attached.contains("cpu") && attached.contains("cpuacct") && attached.size() == 2 src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79745> Why is recursively creating the cgroup needed now when it wasn't before? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/21799/#comment79744> Can you pull the mem isolator clean ups into a separate review? - Ian Downes On June 2, 2014, 6:39 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21799/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 6:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Fixes to enable cgroups to function when initialized via systemd defaults: > + Fix for co-mounting cpu,cpuacct > + Fix for nested cgroups_root='system.slice/mesos-slave.service' > + Diagnostics to propagate error details. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0 > src/linux/cgroups.cpp 142ac43 > src/slave/containerizer/isolators/cgroups/mem.cpp f2509ad > > Diff: https://reviews.apache.org/r/21799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
