----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review44734 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/21799/#comment79229> Is this statement about not creating cgroups recursively still true? src/linux/cgroups.hpp <https://reviews.apache.org/r/21799/#comment79225> Please use the same multi-argument format as above. Try<Nothing> create( const std::string& hierarchy, const std::string& cgroup, bool recursive = false); src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79233> ditto. is the last statement still valid? src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79231> formatting. see above. src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79241> Lets split this into its own review, since this is a change that has bigger impact. src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment79237> formatting. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/21799/#comment79239> if exists.get() is false then this will throw an exception! instead do, (exists.isError() ? exists.error() : "does not exist"); - Vinod Kone On June 3, 2014, 1:39 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21799/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 1:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Fixes to enable cgroups to function when initialized via systemd defaults: > + Fix for co-mounting cpu,cpuacct > + Fix for nested cgroups_root='system.slice/mesos-slave.service' > + Diagnostics to propagate error details. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0 > src/linux/cgroups.cpp 142ac43 > src/slave/containerizer/isolators/cgroups/mem.cpp f2509ad > > Diff: https://reviews.apache.org/r/21799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
