----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review48952 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85781> automatically removed by the kernel? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85782> s/slave can crash/slave could crash/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85787> Seems this function is poorly named if it can optionally also remove filters on the veth? Do you need to explicitly remove filters off the veth, or can you just remove the bind mount and have the kernel clean that side up? - okay, I see it's used for update(). Seems to me this is mixing different functionality. - Ian Downes On July 28, 2014, 4:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 4:53 p.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
