----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review49001 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85828> let's leave a comment on local variable 'pids', to be explicit that the pids are from the device names. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85838> Maybe add a comment here: that we only look at vethX for port ranges during recovery, that's why we add filters to vethX before eth0 and lo, and filter from eth0 and lo from vethX. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85834> s/likely/possible/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85836> I agree that this flags isn't very Cpp style. Shouldn't be hard to break it up into two routines? one operates on eth0 and lo, the other vethX. 'update' calls both; 'cleanup' calls one? But I will leave it to you. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85837> s/is used later/is used again/ typo from me. :) - Chi Zhang On July 29, 2014, 5:44 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 5:44 a.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Bugs: MESOS-1649 > https://issues.apache.org/jira/browse/MESOS-1649 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
