----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review48999 -----------------------------------------------------------
A few questions around my understanding that I'd like to clarify before "ship it". src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85822> The sentinel file is the bind mount which keeps the namespace active? Do we not guarantee the bind mount is present if the forked executor has been signaled to exec? If so, then I don't understand how case 2 can occur. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85823> s/cleanup/clean up/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85824> s/let 'cleanup' function to clean it up later/let the 'cleanup' function clean it up later/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85825> Why not have deallocate() just return if passed an empty interval? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/24020/#comment85826> But it still appends an error such that this function returns Error? My interpretation of the comment is that a failed rm would be ignored. - Ian Downes On July 28, 2014, 10:44 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 10:44 p.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Bugs: MESOS-1649 > https://issues.apache.org/jira/browse/MESOS-1649 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
