----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review49473 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/24194/#comment86543> Add a comment here saying that this variable will be accessed by multiple threads, we reuse the lock for 'watchers' to synchronize. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/24194/#comment86629> It's likely that _poll is called after poll->watcher.async has been stopped. Will that cause any issue when we invoke ev_async_send(loop, async.get()) in _poll? If not, it worths adding a comment here. - Jie Yu On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24194/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 8:05 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1658 > https://issues.apache.org/jira/browse/MESOS-1658 > > > Repository: mesos-git > > > Description > ------- > > See bug. Note that we already had tests for discarding an io::poll. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b > > Diff: https://reviews.apache.org/r/24194/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
