----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review50363 -----------------------------------------------------------
Ship it! Also curious about calling ev_async_send after the watcher is stopped, per Jie's comment. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/24194/#comment88120> Is there a reason that you added this CHECK here but not in 'polled' above? Seems like the same case? - Ben Mahler On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24194/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 8:05 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1658 > https://issues.apache.org/jira/browse/MESOS-1658 > > > Repository: mesos-git > > > Description > ------- > > See bug. Note that we already had tests for discarding an io::poll. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b > > Diff: https://reviews.apache.org/r/24194/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
