> On Aug. 4, 2014, 10:48 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 3709 > > <https://reviews.apache.org/r/24194/diff/1/?file=648813#file648813line3709> > > > > It's likely that _poll is called after poll->watcher.async has been > > stopped. Will that cause any issue when we invoke ev_async_send(loop, > > async.get()) in _poll? > > > > If not, it worths adding a comment here.
Added a comment! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review49473 ----------------------------------------------------------- On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24194/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 8:05 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1658 > https://issues.apache.org/jira/browse/MESOS-1658 > > > Repository: mesos-git > > > Description > ------- > > See bug. Note that we already had tests for discarding an io::poll. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b > > Diff: https://reviews.apache.org/r/24194/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
