----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49761 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/24343/#comment87066> s/are// src/master/master.hpp <https://reviews.apache.org/r/24343/#comment87070> s/head/the head/? src/master/master.hpp <https://reviews.apache.org/r/24343/#comment87071> seems weird for this to be a CHECK, since the users of this class has no idea about the restriction. How about returning an Error instead? Try<process::Event*> nextPermittedEvent() {} Also, s/nextPermittedEvent/nextEvent/ ? src/master/master.cpp <https://reviews.apache.org/r/24343/#comment87073> s/throttle_/throttle/ ? src/master/master.cpp <https://reviews.apache.org/r/24343/#comment87078> +1. This is not really a continuation i.e., never called asynchronously. src/master/master.cpp <https://reviews.apache.org/r/24343/#comment87081> s/EventThrottler returns error:// src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/24343/#comment87084> Isn't this already done by StartMaster()? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/24343/#comment87086> s/reach/processed/ ? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/24343/#comment87087> s/it// src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/24343/#comment87090> how are you making sure the deactivate message is received by the master? - Vinod Kone On Aug. 6, 2014, 5:53 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24343/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 5:53 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >
