-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 4:13 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Addressed comments.
Pulled the logic in EventThrottler into Master::visit() after discussion with
Vinod because it is unable to enforce that the caller (i.e., Master) use its
methods correctly (in the correct order).
Changed it to a dumb struct BoundedRateLimiter the same way other structs
nested in Master are used.
Bugs: MESOS-1578
https://issues.apache.org/jira/browse/MESOS-1578
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207
src/examples/load_generator_framework.cpp
7d94c49cf91bf327ac80f04d9f1a7370996b6ba4
src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797
src/master/master.cpp a925a936bc1cd878f1c9ff63a9dcc4ee808ec7a5
src/tests/cluster.hpp d857fc604f5b47cf9805b37c13051093f486ba31
src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472
Diff: https://reviews.apache.org/r/24343/diff/
Testing
-------
make check
./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000
Thanks,
Jiang Yan Xu
