----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49831 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/24343/#comment87210> this should either be a uint64 (to match the proto) or the proto should be a uint32 (to be reasonable). There's no real benefit to storing this as a size_t. i'll note that we claim to follow the google c++ style guide which states that this should really just be an int unless we know we want to support more than 2^31 messages (unlikely): http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Integer_Types - Dominic Hamon On Aug. 6, 2014, 4:37 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24343/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:37 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 97e4340f7949a261558f09ea533aac0bbb0e40f6 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >
