----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24349/#review49897 -----------------------------------------------------------
Ship it! Any reason not to nest Volume in ContainerInfo? include/mesos/mesos.proto <https://reviews.apache.org/r/24349/#comment87309> s/absolute/Absolute/ Here and below please. - Benjamin Hindman On Aug. 6, 2014, 7:21 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24349/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 7:21 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > Add containerInfo and volumes proto defs. > The new containerInfo will serve as the base Containerizer configuration that > future Containerizers (ie: Docker) can extend from. > Also added a new Volume shared option to configure volume mapping in > containerizers. > > > Diffs > ----- > > include/mesos/mesos.proto 628cce1 > > Diff: https://reviews.apache.org/r/24349/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
