----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24349/#review50016 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/24349/#comment87523> Why would you ever not have a host path? Or are you imagining that we might eventually support volumes mapping from/to remote or other non-host resources? include/mesos/mesos.proto <https://reviews.apache.org/r/24349/#comment87524> Are we really going to have two different (albeit differently namespaced) ContainerInfo messages? How about calling this one "ContainerConfig" or "ContainerConfigInfo" since it doesn't even have the container image (like ContainerInfo does), just additional configuration? How soon can we deprecate the original ContainerInfo? - Adam B On Aug. 7, 2014, 11:10 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24349/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 11:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24349 > > > Diffs > ----- > > include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 > > Diff: https://reviews.apache.org/r/24349/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
