> On Aug. 8, 2014, 7:33 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 829 > > <https://reviews.apache.org/r/24349/diff/4/?file=656505#file656505line829> > > > > Why would you ever not have a host path? Or are you imagining that we > > might eventually support volumes mapping from/to remote or other non-host > > resources?
Some isolator or containerizer doesn't require it, such as Docker that volume mapping doesn't require a host path, as it then chooses a host directory to map it for you that docker itself manages. > On Aug. 8, 2014, 7:33 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 844 > > <https://reviews.apache.org/r/24349/diff/4/?file=656505#file656505line844> > > > > Are we really going to have two different (albeit differently > > namespaced) ContainerInfo messages? > > How about calling this one "ContainerConfig" or "ContainerConfigInfo" > > since it doesn't even have the container image (like ContainerInfo does), > > just additional configuration? > > How soon can we deprecate the original ContainerInfo? It's meant to replace the old one, where we keep the old one for now but deprecating it. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24349/#review50016 ----------------------------------------------------------- On Aug. 8, 2014, 6:10 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24349/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 6:10 a.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24349 > > > Diffs > ----- > > include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 > > Diff: https://reviews.apache.org/r/24349/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
