> On Sept. 16, 2014, 3:38 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [25695] > > > > Failed command: ./configure > > > > Error: > > checking build system type... x86_64-unknown-linux-gnu > > checking host system type... x86_64-unknown-linux-gnu > > checking target system type... x86_64-unknown-linux-gnu > > checking for a BSD-compatible install... /usr/bin/install -c > > checking whether build environment is sane... yes > > checking for a thread-safe mkdir -p... /bin/mkdir -p > > checking for gawk... no > > checking for mawk... mawk > > checking whether make sets $(MAKE)... yes > > checking whether make supports nested variables... yes > > checking for style of include used by make... GNU > > checking for gcc... gcc > > checking whether the C compiler works... yes > > checking for C compiler default output file name... a.out > > checking for suffix of executables... > > checking whether we are cross compiling... no > > checking for suffix of object files... o > > checking whether we are using the GNU C compiler... yes > > checking whether gcc accepts -g... yes > > checking for gcc option to accept ISO C89... none needed > > checking whether gcc understands -c and -o together... yes > > checking dependency style of gcc... gcc3 > > checking for ar... ar > > checking the archiver (ar) interface... ar > > checking how to print strings... printf > > checking for a sed that does not truncate output... /bin/sed > > checking for grep that handles long lines and -e... /bin/grep > > checking for egrep... /bin/grep -E > > checking for fgrep... /bin/grep -F > > checking for ld used by gcc... /usr/bin/ld > > checking if the linker (/usr/bin/ld) is GNU ld... yes > > checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B > > checking the name lister (/usr/bin/nm -B) interface... BSD nm > > checking whether ln -s works... yes > > checking the maximum length of command line arguments... 1572864 > > checking whether the shell understands some XSI constructs... yes > > checking whether the shell understands "+="... yes > > checking how to convert x86_64-unknown-linux-gnu file names to > > x86_64-unknown-linux-gnu format... func_convert_file_noop > > checking how to convert x86_64-unknown-linux-gnu file names to toolchain > > format... func_convert_file_noop > > checking for /usr/bin/ld option to reload object files... -r > > checking for objdump... objdump > > checking how to recognize dependent libraries... pass_all > > checking for dlltool... no > > checking how to associate runtime and link libraries... printf %s\n > > checking for g++... g++ > > checking whether we are using the GNU C++ compiler... yes > > checking whether g++ accepts -g... yes > > checking dependency style of g++... gcc3 > > checking for archiver @FILE support... @ > > checking for strip... strip > > checking for ranlib... ranlib > > checking command to parse /usr/bin/nm -B output from gcc object... ok > > checking for sysroot... no > > checking for mt... mt > > checking if mt is a manifest tool... no > > checking how to run the C preprocessor... gcc -E > > checking for ANSI C header files... yes > > checking for sys/types.h... yes > > checking for sys/stat.h... yes > > checking for stdlib.h... yes > > checking for string.h... yes > > checking for memory.h... yes > > checking for strings.h... yes > > checking for inttypes.h... yes > > checking for stdint.h... yes > > checking for unistd.h... yes > > checking for dlfcn.h... yes > > checking for objdir... .libs > > checking if gcc supports -fno-rtti -fno-exceptions... no > > checking for gcc option to produce PIC... -fPIC -DPIC > > checking if gcc PIC flag -fPIC -DPIC works... yes > > checking if gcc static flag -static works... yes > > checking if gcc supports -c -o file.o... yes > > checking if gcc supports -c -o file.o... (cached) yes > > checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared > > libraries... yes > > checking whether -lc should be explicitly linked in... no > > checking dynamic linker characteristics... GNU/Linux ld.so > > checking how to hardcode library paths into programs... immediate > > checking whether stripping libraries is possible... yes > > checking if libtool supports shared libraries... yes > > checking whether to build shared libraries... yes > > checking whether to build static libraries... yes > > checking how to run the C++ preprocessor... g++ -E > > checking for ld used by g++... /usr/bin/ld -m elf_x86_64 > > checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes > > checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared > > libraries... yes > > checking for g++ option to produce PIC... -fPIC -DPIC > > checking if g++ PIC flag -fPIC -DPIC works... yes > > checking if g++ static flag -static works... yes > > checking if g++ supports -c -o file.o... yes > > checking if g++ supports -c -o file.o... (cached) yes > > checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared > > libraries... yes > > checking dynamic linker characteristics... (cached) GNU/Linux ld.so > > checking how to hardcode library paths into programs... immediate > > configure: creating ./config.lt > > config.lt: creating libtool > > configure: Setting up build environment for x86_64 linux-gnu > > checking whether we are using the GNU C++ compiler... (cached) yes > > checking whether g++ accepts -g... (cached) yes > > checking dependency style of g++... (cached) gcc3 > > checking whether we are using the GNU C compiler... (cached) yes > > checking whether gcc accepts -g... (cached) yes > > checking for gcc option to accept ISO C89... (cached) none needed > > checking whether gcc understands -c and -o together... (cached) yes > > checking dependency style of gcc... (cached) gcc3 > > checking for pkg-config... /usr/bin/pkg-config > > checking pkg-config is at least version 0.9.0... yes > > checking for SYSTEMD... no > > configure: error: Package requirements (libsystemd-daemon) were not met: > > > > No package 'libsystemd-daemon' found > > > > Consider adjusting the PKG_CONFIG_PATH environment variable if you > > installed software in a non-standard prefix. > > > > Alternatively, you may set the environment variables SYSTEMD_CFLAGS > > and SYSTEMD_LIBS to avoid the need to call pkg-config. > > See the pkg-config man page for more details.
whoops, fix coming. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53534 ----------------------------------------------------------- On Sept. 16, 2014, 3:03 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25695/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 3:03 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > This update enables support for systemd co-managed cgroup controllers > > > Diffs > ----- > > configure.ac c4b4391 > src/linux/cgroups.cpp 5093b4c > src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 > > Diff: https://reviews.apache.org/r/25695/diff/ > > > Testing > ------- > > systemctl start mesos-master mesos-slave > several runs of 'mesos execute' to verify creation and cleanup. > systemctl stop mesos-master mesos-slave > > make check > > > Thanks, > > Timothy St. Clair > >
