> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: > > configure.ac, lines 470-472 > > <https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470> > > > > Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, > > some people have issues when bootstrapping if `PKG_CHECK_MODULES` is used. > > Timothy St. Clair wrote: > Could we determine what the root cause is before we through it out? I > would like to know why it is an issue. > > Jie Yu wrote: > Yeah, we tried but couldn't find out the cause. That's the reason we have > the following patches: > > ``` > commit 358901a6d56ff9179ffa67077994ed618044179c > Author: Jie Yu <yujie....@gmail.com> > Date: Wed Aug 27 11:55:46 2014 -0700 > > Replaced PKG_CHECK_MODULES with AC_CHECKs in libprocess configure.ac. > > Review: https://reviews.apache.org/r/25031 > > commit 66ecc377917581b891a2569b3343456a3d4c3be1 > Author: Jie Yu <yujie....@gmail.com> > Date: Wed Aug 27 11:52:59 2014 -0700 > > Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac. > > Review: https://reviews.apache.org/r/25030 > ```
Does *this seem familiar? http://myitcorner.com/blog/?p=207 I was unable to repro in my env, but it sounds like the previous situation. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53837 ----------------------------------------------------------- On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25695/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 6:19 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > This update enables support for systemd co-managed cgroup controllers > > > Diffs > ----- > > configure.ac c4b4391 > src/linux/cgroups.cpp 5093b4c > src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 > > Diff: https://reviews.apache.org/r/25695/diff/ > > > Testing > ------- > > systemctl start mesos-master mesos-slave > several runs of 'mesos execute' to verify creation and cleanup. > systemctl stop mesos-master mesos-slave > > make check > > > Thanks, > > Timothy St. Clair > >
