----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53837 -----------------------------------------------------------
This more looks like a hack. What if people compile mesos on a machine without systemd and run it on a machine with systemd? I am in favor of a dynamic solution. Have you considered the suggestion I gave last time? configure.ac <https://reviews.apache.org/r/25695/#comment93694> Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, some people have issues when bootstrapping if `PKG_CHECK_MODULES` is used. src/linux/cgroups.cpp <https://reviews.apache.org/r/25695/#comment93697> So you never cleanup other cgroups (like memory) on machines with systemd? ook - Jie Yu On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25695/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 6:19 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > This update enables support for systemd co-managed cgroup controllers > > > Diffs > ----- > > configure.ac c4b4391 > src/linux/cgroups.cpp 5093b4c > src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 > > Diff: https://reviews.apache.org/r/25695/diff/ > > > Testing > ------- > > systemctl start mesos-master mesos-slave > several runs of 'mesos execute' to verify creation and cleanup. > systemctl stop mesos-master mesos-slave > > make check > > > Thanks, > > Timothy St. Clair > >
