-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review53945
-----------------------------------------------------------
Bad patch!
Reviews applied: [25789, 25818]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.21.0"; then find "mesos-0.21.0" -type d ! -perm -200 -exec
chmod u+w {} ';' && rm -rf "mesos-0.21.0" || { sleep 5 && rm -rf
"mesos-0.21.0"; }; else :; fi
test -d "mesos-0.21.0" || mkdir "mesos-0.21.0"
(cd 3rdparty && make top_distdir=../mesos-0.21.0
distdir=../mesos-0.21.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess && make top_distdir=../../mesos-0.21.0
distdir=../../mesos-0.21.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.21.0/3rdparty/libprocess" || mkdir
"../../mesos-0.21.0/3rdparty/libprocess"
(cd 3rdparty && make top_distdir=../../../mesos-0.21.0
distdir=../../../mesos-0.21.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout && make top_distdir=../../../../mesos-0.21.0
distdir=../../../../mesos-0.21.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[5]: *** No rule to make target `tests/path.cpp', needed by `distdir'.
Stop.
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: *** [distdir] Error 1
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[3]: *** [distdir] Error 1
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: *** [distdir] Error 1
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On Sept. 19, 2014, 6:59 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25818/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 6:59 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Switch path::join() to be variadic
>
> Also fix a bug in strings::trim() where when the string was just characters
> to be trimmed, nothing would be trimmed.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am
> bd1dc8df0259a318a9171a9c045a223800e64f47
> 3rdparty/libprocess/3rdparty/stout/Makefile.am
> 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
> bc6920a24d920c809e36a2a3da1810e52d0db101
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
>
> Diff: https://reviews.apache.org/r/25818/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cody Maloney
>
>