> On Sept. 29, 2014, 5:21 a.m., Adam B wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 34
> > <https://reviews.apache.org/r/25818/diff/5/?file=706722#file706722line34>
> >
> > Excuse my ignorance of variadic templates, but could one write
> > path::join("/") or path::join("")? If those would compile, they would be
> > easy edge cases.
path::join("/"); doesn't compile (Although I could make it if we want).
It would require another specialization of strings::join() which takes only one
argument (The string to join by), or an explicit specialization of path::join()
to deal with the single element case (Take a string and just return it).
> On Sept. 29, 2014, 5:21 a.m., Adam B wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 27-29
> > <https://reviews.apache.org/r/25818/diff/5/?file=706722#file706722line27>
> >
> > Aren't two of these lines the same? Am I missing something?
The two identical lines are indeed. Removed the second one.
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review54793
-----------------------------------------------------------
On Sept. 29, 2014, 6:01 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25818/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 6:01 p.m.)
>
>
> Review request for mesos, Adam B and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Switch path::join() to be variadic.
>
> Updated now that 25789 has landed
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25818/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cody Maloney
>
>
