----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review53965 -----------------------------------------------------------
Patch looks great! Reviews applied: [25789, 25818] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 4:08 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25818/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 4:08 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Switch path::join() to be variadic > > Also fix a bug in strings::trim() where when the string was just characters > to be trimmed, nothing would be trimmed. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > bd1dc8df0259a318a9171a9c045a223800e64f47 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > bc6920a24d920c809e36a2a3da1810e52d0db101 > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 > > Diff: https://reviews.apache.org/r/25818/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cody Maloney > >
