> On Sept. 29, 2014, 9:41 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 139 > > <https://reviews.apache.org/r/26150/diff/1/?file=708531#file708531line139> > > > > I'd like to start using all the nice C++11 features, but not sure if we > > want to start introducing them in our benchmark code? > > Dominic Hamon wrote: > as long as we're checking for support in configure, it should be fine.
I'm not sure if I didn't get the message, but if that's the case we should be notifying everyone that what C++11 features we can be using right? I only get the auto parameter email, but not the other ones that's in this rb. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review54886 ----------------------------------------------------------- On Sept. 29, 2014, 9:38 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26150/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 9:38 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1840 > https://issues.apache.org/jira/browse/MESOS-1840 > > > Repository: mesos-git > > > Description > ------- > > A benchmark for libprocess. > It forks num_proc times and launched num_threads "libprocess" processes in > each child. They are aware of the "master"'s (parent) address and all play > ping pong with it. > This benchmark measures throughput in terms of the number of RPCs handled per > second using persistent (linked) connections. > > A new test file (benchmarks) is introduced because we want to fork before > libprocess is initialized. This allows us to prevent short-circuiting of > message passing between processes under the same ProcessManager. This way we > force the execution path of the underlying event management system. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 616618e > 3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26150/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
