----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review56442 -----------------------------------------------------------
3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96773> This is the first time we use std::thread - do you have some references that it is supported across our graced compilers? Same for mutex 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96775> 2 newlines between implementing functions. 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96771> This is a bit counter intuitive (from the 4 space argument wrapping), but for intializer lists take a look at for example: https://github.com/apache/mesos/blob/master/src/docker/docker.hpp#L65 It becomes: FooBarBaz( int x, int y, int z) : x(x), y(y), z(z) { } Does that make sense? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96772> setLink? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96774> Bring '{' down - here and below. 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96776> Was this the lock that depended on Dominic's configure patch? If so, can you add it as a dependency? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96781> Can we use the latch (latch.hpp) abstraction here? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96777> Mind throwing in a comment here on why you need this helper (thread entry?) 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96760> Any reason not to use plain int's? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96751> Why int64? It is only a count down from 4 right? Also, shouldn't moreToLaunch be size_t to be consistent? 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/26150/#comment96778> Stout has a time abstraction you could use: https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/time.hpp - Niklas Nielsen On Oct. 13, 2014, 1:38 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26150/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 1:38 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1840 > https://issues.apache.org/jira/browse/MESOS-1840 > > > Repository: mesos-git > > > Description > ------- > > A benchmark for libprocess. > It forks num_proc times and launched num_threads "libprocess" processes in > each child. They are aware of the "master"'s (parent) address and all play > ping pong with it. > This benchmark measures throughput in terms of the number of RPCs handled per > second using persistent (linked) connections. > > A new test file (benchmarks) is introduced because we want to fork before > libprocess is initialized. This allows us to prevent short-circuiting of > message passing between processes under the same ProcessManager. This way we > force the execution path of the underlying event management system. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 616618e > 3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26150/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
