> On Oct. 13, 2014, 9:47 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 25 > > <https://reviews.apache.org/r/26150/diff/3/?file=719696#file719696line25> > > > > This is the first time we use std::thread - do you have some references > > that it is supported across our graced compilers? Same for mutex
Removed use of thread. > On Oct. 13, 2014, 9:47 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 95 > > <https://reviews.apache.org/r/26150/diff/3/?file=719696#file719696line95> > > > > Was this the lock that depended on Dominic's configure patch? If so, > > can you add it as a dependency? Remove use of mutex / unique_lock; use Latch instead. > On Oct. 13, 2014, 9:47 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 97 > > <https://reviews.apache.org/r/26150/diff/3/?file=719696#file719696line97> > > > > Can we use the latch (latch.hpp) abstraction here? Yep. Done. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review56442 ----------------------------------------------------------- On Oct. 14, 2014, 9:27 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26150/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 9:27 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1840 > https://issues.apache.org/jira/browse/MESOS-1840 > > > Repository: mesos-git > > > Description > ------- > > A benchmark for libprocess. > It forks num_proc times and launched num_threads "libprocess" processes in > each child. They are aware of the "master"'s (parent) address and all play > ping pong with it. > This benchmark measures throughput in terms of the number of RPCs handled per > second using persistent (linked) connections. > > A new test file (benchmarks) is introduced because we want to fork before > libprocess is initialized. This allows us to prevent short-circuiting of > message passing between processes under the same ProcessManager. This way we > force the execution path of the underlying event management system. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 616618e > 3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26150/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
