> On Oct. 1, 2014, 5:08 p.m., Ian Downes wrote: > > I'm curious why this is useful. Is there some code elsewhere that will > > depend on knowing these parameters? If so, why not just expose them as > > constants?
Yes, I need these constants for graceful shutdown tests. I used static functions for because I thought we agreed not to use constants for non-POD types here: https://issues.apache.org/jira/browse/MESOS-1023. Does this make sense? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55084 ----------------------------------------------------------- On Oct. 1, 2014, 2:12 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26229/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 2:12 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Lower and upper bounds for the poll interval are refactored as static > functions visible for outer world. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp 9de5336 > 3rdparty/libprocess/src/reap.cpp ac14a86 > > Diff: https://reviews.apache.org/r/26229/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
