> On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/reap.cpp, lines 124-127 > > <https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124> > > > > Why do you need a variable for this? Can't this just be a 'return' > > statement? > > > > If there's a reason to keep this statement separate from the return, > > please avoid 'auto', we'd like to start using it very conservatively.
Naming the result of the expression serves two purposes here: clarity about what we calculate and return and facilitating NRWO. Since auto is replaced, I mark this issue as fixed, please reopen if you think further discussion about `return` is needed. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55582 ----------------------------------------------------------- On Oct. 6, 2014, 1:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26229/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 1:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Lower and upper bounds for the poll interval are refactored as static > functions visible to outer world. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp 9de5336 > 3rdparty/libprocess/src/reap.cpp ac14a86 > > Diff: https://reviews.apache.org/r/26229/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >