----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55583 -----------------------------------------------------------
3rdparty/libprocess/include/process/reap.hpp <https://reviews.apache.org/r/26229/#comment95944> Can you add some more description to this ticket? If a caller is to use these values, their names seem pretty generic: ``` // What is this? No association with 'reaping' or 'reaper' in this call. process::lowPollInterval(); ``` For constants like this, we expose them in `ALL_CAPS()`. - Ben Mahler On Oct. 6, 2014, 1:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26229/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 1:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Lower and upper bounds for the poll interval are refactored as static > functions visible to outer world. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp 9de5336 > 3rdparty/libprocess/src/reap.cpp ac14a86 > > Diff: https://reviews.apache.org/r/26229/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
