> On Oct. 2, 2014, 7:49 a.m., Timothy Chen wrote: > > src/exec/exec.cpp, line 739 > > <https://reviews.apache.org/r/25434/diff/4/?file=709150#file709150line739> > > > > I'm not sure this should be at the WARNING level, as it's not really > > expected to have it set all the time. IMHO it should be INFO
We actually expect it to be set explicitly in order to avoid situations where slave uses one value and executor another. > On Oct. 2, 2014, 7:49 a.m., Timothy Chen wrote: > > src/tests/slave_tests.cpp, line 1023 > > <https://reviews.apache.org/r/25434/diff/4/?file=709164#file709164line1023> > > > > Times(1) is default, can ignore the call. To the best of my knowledge, we always explicitly write `Times(1)` in such cases. > On Oct. 2, 2014, 7:49 a.m., Timothy Chen wrote: > > src/tests/slave_tests.cpp, line 1061 > > <https://reviews.apache.org/r/25434/diff/4/?file=709164#file709164line1061> > > > > EXPECT_TRUE Good catch! - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review55196 ----------------------------------------------------------- On Oct. 2, 2014, 7:17 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, > and Timothy St. Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/Makefile.am 27c42df > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp cbc8750 > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 9a29489 > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 32e51d2 > src/slave/utils.hpp PRE-CREATION > src/slave/utils.cpp PRE-CREATION > src/tests/containerizer.cpp a17e1e0 > src/tests/mesos.hpp 957e223 > src/tests/slave_tests.cpp 69be28f > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4) > > WIP: digging into the failure of the SlaveTest.MesosExecutorForceShutdown > test revealed an issue with signal escalation in CommandExecutor. That needs > more time to be resolved. > > > Thanks, > > Alexander Rukletsov > >
