----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review55196 -----------------------------------------------------------
src/exec/exec.cpp <https://reviews.apache.org/r/25434/#comment95590> I'm not sure this should be at the WARNING level, as it's not really expected to have it set all the time. IMHO it should be INFO src/slave/utils.cpp <https://reviews.apache.org/r/25434/#comment95591> I think the usual style is to move mesos::internal::slave::SHUTDOWN_TIMEOUT_DELTA * to the next line src/slave/utils.cpp <https://reviews.apache.org/r/25434/#comment95592> Log the timeout value src/tests/slave_tests.cpp <https://reviews.apache.org/r/25434/#comment95593> Times(1) is default, can ignore the call. src/tests/slave_tests.cpp <https://reviews.apache.org/r/25434/#comment95594> EXPECT_TRUE src/tests/slave_tests.cpp <https://reviews.apache.org/r/25434/#comment95595> ditto - Timothy Chen On Oct. 2, 2014, 7:17 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, > and Timothy St. Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/Makefile.am 27c42df > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp cbc8750 > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 9a29489 > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 32e51d2 > src/slave/utils.hpp PRE-CREATION > src/slave/utils.cpp PRE-CREATION > src/tests/containerizer.cpp a17e1e0 > src/tests/mesos.hpp 957e223 > src/tests/slave_tests.cpp 69be28f > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4) > > WIP: digging into the failure of the SlaveTest.MesosExecutorForceShutdown > test revealed an issue with signal escalation in CommandExecutor. That needs > more time to be resolved. > > > Thanks, > > Alexander Rukletsov > >
