> On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote: > > src/exec/exec.cpp, line 82 > > <https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line82> > > > > Maybe I'm missing something, but is there a reason we don't check > > before a delay? If ShutdownProcess is spawned, it's possible all other > > processes in the group have already cleaned up. > > Alexander Rukletsov wrote: > Good questions. Can this be related to non-native bindings? > > Timothy St. Clair wrote: > Perhaps we can open a separate JIRA on this issue as it was here before.
https://issues.apache.org/jira/browse/MESOS-1823 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review53038 ----------------------------------------------------------- On Sept. 18, 2014, 11:03 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, > and Timothy St. Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/Makefile.am 9b973e5 > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp cbc8750 > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 0febbac > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 21e0021 > src/slave/utils.hpp PRE-CREATION > src/slave/utils.cpp PRE-CREATION > src/tests/containerizer.cpp a17e1e0 > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4) > > > Thanks, > > Alexander Rukletsov > >
