----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56042 -----------------------------------------------------------
src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment96397> Not yours, but can you add a comment describing the test? src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment96396> Any reason for these changes? Do you have any reference on if '>>' disambiguation is supported by our graced compilers? Here and below. src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment96399> Mind expanding a bit on the expected state you are inspecting (and reason for the newly added code)? src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment96398> Can you do this more reliably? For example setting an expectation for the message to be sent? If not - mind commenting on why? :-) - Niklas Nielsen On Oct. 9, 2014, 10:05 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25250/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 10:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-1736 > https://issues.apache.org/jira/browse/MESOS-1736 > > > Repository: mesos-git > > > Description > ------- > > When a framework is shut down e.g. by calling driver.stop() from the > scheduler, running tasks are marked KILLED before migrating them to completed. > > > Diffs > ----- > > src/master/master.cpp cb46cec > src/tests/master_tests.cpp d9dc40c > > Diff: https://reviews.apache.org/r/25250/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Alexander Rukletsov > >
