> On Oct. 9, 2014, 8:01 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, line 168 > > <https://reviews.apache.org/r/25250/diff/6/?file=716710#file716710line168> > > > > Any reason for these changes? Do you have any reference on if '>>' > > disambiguation is supported by our graced compilers? > > > > Here and below.
To the best of my knowledge all supported compilers handle `>>` correctly and we agreed to make use of it in new patches. So I decided to clean-up while modifying the test. But can rollback it if you prefer the conservative way. > On Oct. 9, 2014, 8:01 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, line 165 > > <https://reviews.apache.org/r/25250/diff/6/?file=716710#file716710line165> > > > > Not yours, but can you add a comment describing the test? Sure. > On Oct. 9, 2014, 8:01 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, line 247 > > <https://reviews.apache.org/r/25250/diff/6/?file=716710#file716710line247> > > > > Mind expanding a bit on the expected state you are inspecting (and > > reason for the newly added code)? Expanded a comment above and one below. > On Oct. 9, 2014, 8:01 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 253-255 > > <https://reviews.apache.org/r/25250/diff/6/?file=716710#file716710line253> > > > > Can you do this more reliably? For example setting an expectation for > > the message to be sent? If not - mind commenting on why? :-) My understanding is that this sequence guarantees all non-delayed messages in the mailbox are processed. I want to be sure that the `UnregisterFrameworkMessage` is processed by the master before I ask for the `state.json`. I've expanded a comment a bit, please let me know if there is a better way to achieve this. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56042 ----------------------------------------------------------- On Oct. 9, 2014, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25250/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 5:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-1736 > https://issues.apache.org/jira/browse/MESOS-1736 > > > Repository: mesos-git > > > Description > ------- > > When a framework is shut down e.g. by calling driver.stop() from the > scheduler, running tasks are marked KILLED before migrating them to completed. > > > Diffs > ----- > > src/master/master.cpp cb46cec > src/tests/master_tests.cpp d9dc40c > > Diff: https://reviews.apache.org/r/25250/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Alexander Rukletsov > >
