----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review56614 -----------------------------------------------------------
Bad patch! Reviews applied: [26150] Failed command: ./support/mesos-style.py Error: Checking 520 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/src/tests/benchmarks.cpp:127: Missing space after ; [whitespace/semicolon] [3] Total errors found: 1 - Mesos ReviewBot On Oct. 14, 2014, 9:30 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26150/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 9:30 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1840 > https://issues.apache.org/jira/browse/MESOS-1840 > > > Repository: mesos-git > > > Description > ------- > > A benchmark for libprocess. > It forks num_proc times and launched num_threads "libprocess" processes in > each child. They are aware of the "master"'s (parent) address and all play > ping pong with it. > This benchmark measures throughput in terms of the number of RPCs handled per > second using persistent (linked) connections. > > A new test file (benchmarks) is introduced because we want to fork before > libprocess is initialized. This allows us to prevent short-circuiting of > message passing between processes under the same ProcessManager. This way we > force the execution path of the underlying event management system. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 616618e > 3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26150/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >