----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27461/#review59455 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/27461/#comment100739> I think the following would be a bit easier on the eye, no? ```while (currentProcess.isSome() && !currentProcess.get().zombie))``` - Till Toenshoff On Nov. 1, 2014, 2:52 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27461/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 2:52 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-2025 > https://issues.apache.org/jira/browse/MESOS-2025 > > > Repository: mesos-git > > > Description > ------- > > Reparenting does not always assign pid 1 (/sbin/init). If there is a user > init such as init --user with some other pid, this will be the new parent. > Modify os_tests to check up the parent tree, and succeed if there is a path > to pid 1 without zombies along the way. > This is not the cleanest fix, but I'm having trouble finding a way to find > the appropriate init to check for. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3f39017 > > Diff: https://reviews.apache.org/r/27461/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
