----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27461/#review59690 -----------------------------------------------------------
Ship it! Could you please add to the comment to clarify why this is done, i.e., because some systems don't reparent to init pid 1. Thanks! - Ian Downes On Nov. 3, 2014, 4:17 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27461/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 4:17 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-2025 > https://issues.apache.org/jira/browse/MESOS-2025 > > > Repository: mesos-git > > > Description > ------- > > Reparenting does not always assign pid 1 (/sbin/init). If there is a user > init such as init --user with some other pid, this will be the new parent. > Modify os_tests to check that the subtree has been reparented to a process > different from its original parent (a.k.a. child) and that it is not a zombie. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3f39017 > > Diff: https://reviews.apache.org/r/27461/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >