> On Nov. 4, 2014, 12:37 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 661 > > <https://reviews.apache.org/r/27461/diff/3/?file=747878#file747878line661> > > > > Couldn't this be "grandchild.children.front()"?
we'd have to keep a reference to the object rather than the implicit conversion to pid_t for that to work. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27461/#review59692 ----------------------------------------------------------- On Nov. 4, 2014, 12:36 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27461/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:36 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-2025 > https://issues.apache.org/jira/browse/MESOS-2025 > > > Repository: mesos-git > > > Description > ------- > > Reparenting does not always assign pid 1 (/sbin/init). If there is a user > init such as init --user with some other pid, this will be the new parent. > Modify os_tests to check that the subtree has been reparented to a process > different from its original parent (a.k.a. child) and that it is not a zombie. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3f39017 > > Diff: https://reviews.apache.org/r/27461/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
