> On Nov. 10, 2014, 2:20 p.m., Alexander Rukletsov wrote: > > src/sched/flags.hpp, lines 51-56 > > <https://reviews.apache.org/r/27806/diff/1/?file=756738#file756738line51> > > > > Can we extract it and put somewhere as a string constant?
That is a very good point and I actually thought the same a while ago - see https://issues.apache.org/jira/browse/MESOS-1997 We should indeed do that ASAP - it got pretty bad now that we introduced the modules flag in four places. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/#review60595 ----------------------------------------------------------- On Nov. 10, 2014, 1:27 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27806/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:27 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2002 > https://issues.apache.org/jira/browse/MESOS-2002 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/sched/flags.hpp 62a634b > src/sched/sched.cpp 8ca0526 > > Diff: https://reviews.apache.org/r/27806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
