> On Nov. 10, 2014, 7:56 p.m., Niklas Nielsen wrote: > > LGTM. I agree with Alex that this ended up being duplicated too many times > > and will become a pain to maintain consistently. We haven't had this > > problem before, but maybe it's worth a JIRA ticket?
https://issues.apache.org/jira/browse/MESOS-1997 as noted above :) > On Nov. 10, 2014, 7:56 p.m., Niklas Nielsen wrote: > > src/sched/sched.cpp, line 304 > > <https://reviews.apache.org/r/27806/diff/1/?file=756739#file756739line304> > > > > Fly by style fix? The check and use ties together don't they? True - the subsequent patch (27812) will change that - hope that is good enough :) - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/#review60655 ----------------------------------------------------------- On Nov. 10, 2014, 1:27 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27806/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:27 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2002 > https://issues.apache.org/jira/browse/MESOS-2002 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/sched/flags.hpp 62a634b > src/sched/sched.cpp 8ca0526 > > Diff: https://reviews.apache.org/r/27806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
