----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/#review60655 -----------------------------------------------------------
LGTM. I agree with Alex that this ended up being duplicated too many times and will become a pain to maintain consistently. We haven't had this problem before, but maybe it's worth a JIRA ticket? src/sched/sched.cpp <https://reviews.apache.org/r/27806/#comment102032> Fly by style fix? The check and use ties together don't they? - Niklas Nielsen On Nov. 10, 2014, 5:27 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27806/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 5:27 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2002 > https://issues.apache.org/jira/browse/MESOS-2002 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/sched/flags.hpp 62a634b > src/sched/sched.cpp 8ca0526 > > Diff: https://reviews.apache.org/r/27806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
