----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review60767 -----------------------------------------------------------
Looks great, but I'm not convinced you need a hashmap of Authenticators. src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27760/#comment102176> s/crammd5_authenticator/crammd5_authenticator_session/ ? src/master/master.hpp <https://reviews.apache.org/r/27760/#comment102177> This hashmap isn't really necessary yet, since we only allow a single authenticator, right? If/when we do support multiple authenticators, we may want to keep them ordered somehow, so how about you just store a single Owned<Authenticator> for now, and we can upgrade to a hashmap/whatever later. src/master/master.cpp <https://reviews.apache.org/r/27760/#comment102178> ... for pid '" << from << "'"; - Adam B On Nov. 9, 2014, 1:47 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2014, 1:47 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp a23bf5d > src/master/master.hpp 687f178 > src/master/master.cpp 5712b17 > src/tests/cram_md5_authentication_tests.cpp 1ed2312 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
