> On Nov. 14, 2014, 8:10 a.m., Adam B wrote: > > src/master/master.cpp, line 379 > > <https://reviews.apache.org/r/27760/diff/5/?file=762954#file762954line379> > > > > Should we even bother reading this flag or reading in the credentials > > file if neither --authenticate flag is set?
the reason we originally loaded credentials despite "--authenticate" flag being unset is so that it easy to upgrade scheduler and masters. "--authenticate" means only only authenticated frameworks can register. not specifying "--authenticate" means allowing authenticating or non-authenticating frameworks to register. maybe the flag should've been more explicitly named. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review61413 ----------------------------------------------------------- On Nov. 13, 2014, 11:52 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 11:52 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp d739a02 > src/master/master.hpp 47f3bc9 > src/master/master.cpp 0f89d1f > src/tests/cram_md5_authentication_tests.cpp a356aa1 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
