> On Nov. 10, 2014, 10:44 a.m., Adam B wrote: > > src/authentication/authenticator.hpp, line 49 > > <https://reviews.apache.org/r/27760/diff/4/?file=755828#file755828line49> > > > > So, if I want to update credentials, I have to kill my Master (hence > > Authenticator) and create+initialize a new one? What would it take to > > live-update credentials?
That wasnt part of the original implementation but we actually might want to introduce such feature later on. See MESOS-2093. > On Nov. 10, 2014, 10:44 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.hpp, line 551 > > <https://reviews.apache.org/r/27760/diff/4/?file=755829#file755829line551> > > > > s/CRAMMD5AuthenticatorProcess/CRAMMD5AuthenticatorSessionProcess/ ? Yes, will update. > On Nov. 10, 2014, 10:44 a.m., Adam B wrote: > > src/master/master.cpp, lines 3932-3934 > > <https://reviews.apache.org/r/27760/diff/4/?file=755831#file755831line3932> > > > > When would this ever happen? If it's not possible, a CHECK might be > > more appropriate; whereas if it is possible, is an EXIT too strong? > > > > And if you're keeping the error message, I'd suggest the simpler > > "Authenticator 'foo' not initialized" ```CHECK(authenticator != NULL) << "Authenticator '" << authenticatorNames[0] << "' not initialized";``` Mind that CHECK_NOTNULL doesnt offer error messages. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review60562 ----------------------------------------------------------- On Nov. 9, 2014, 9:47 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2014, 9:47 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp a23bf5d > src/master/master.hpp 687f178 > src/master/master.cpp 5712b17 > src/tests/cram_md5_authentication_tests.cpp 1ed2312 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
